# Mozilla est précis...
## Approuvé by Add-ons Review Team about a month ago
This version has been screened and approved for the public. Keep in mind that other reviewers may look into this version in the future and determine that it requires changes or should be taken down.
Thank you!
## Rejet programmé by Add-ons Review Team about a month ago
This add-on didn't pass review because of the following problems:
1) Please provide us with detailed information on how to test this add-on. If authentication to a website is necessary, give us a test username and password to facilitate our work. This can be provided in the Whiteboard field, which can be found in the Edit Listing page under the Technical Details section. This information is only available to reviewers.
Rejeté by Add-ons Review Team 27 days ago
Automatic rejection after grace period ended.
---
## Code source envoyé by Axiom-Team 22 days ago
## Rejet programmé by Add-ons Review Team 19 days ago
This add-on didn't pass review because of the following problems:
1) Reproducing the submitted release version based on the provided source code package and instructions failed.
You can access the console output at https://prod.pastebin.prod.webservices.mozgcp.net/K7qcjEX3 .
Environment used for building: Node 18.19.0, npm 10.2.3 on Ubuntu 20.04 LTS x64 (10GB RAM, 6 CPUs)
Please test your build in a clean environment to make sure it is reproducible. If necessary, update the source code package and/or the instructions to reproduce.
Please read through the instructions at https://extensionworkshop.com/documentation/publish/source-code-submission/ .
## Code source envoyé by Axiom-Team 18 days ago
## Réponse d’un développeur by Axiom-Team 18 days ago
I just uploaded a new zip with the full source code, from our git: https://git.duniter.org/clients/duniter-connect
This is the successful logs from I where build is working: https://prod.pastebin.prod.webservices.mozgcp.net/vnd2BpUW#L16
Steps to reproduice:
- nvm use 18
- npm i -g yarn
- yarn install
- yarn build
## Réponse d’un relecteur by Add-ons Review Team 13 days ago
I've built it again on Ubuntu 20.04 using the instructions you provided in the last reply: node 18, yarn, yarn build, but the following files are different from the ones in the final add-on zip:
duniter_connect_\duniter-connect.zip\extension.js
duniter_connect_\duniter-connect.zip\background.js
You can see the log at https://prod.pastebin.prod.webservices.mozgcp.net/A7kcDeHz and build at https://we.tl/t-ZsZmlYUb7I . Please test your build in a clean environment to make sure it is reproducible. If necessary, update the source code package and/or the instructions to reproduce.
Please read through the instructions at https://extensionworkshop.com/documentation/publish/source-code-submission/ .
Rejeté by Add-ons Review Team 5 days ago
Automatic rejection after grace period ended.
---
## Code source envoyé by Axiom-Team 13 days ago
## Rejet programmé by Add-ons Review Team 8 days ago
This add-on didn't pass review because of the following problems:
1) I've built it again on Ubuntu 20.04 using the instructions you provided in the last reply: node 18, yarn, yarn build, but the following files are different from the ones in the final add-on zip:
duniter_connect_\duniter-connect.zip\extension.js
duniter_connect_\duniter-connect.zip\background.js
You can see the log at https://prod.pastebin.prod.webservices.mozgcp.net/Exv5qMvT and build at https://we.tl/t-kndlaVSdld. Please test your build in a clean environment to make sure it is reproducible. If necessary, update the source code package and/or the instructions to reproduce.
Please read through the instructions at https://extensionworkshop.com/documentation/publish/source-code-submission/ .
## Réponse d’un développeur by Axiom-Team 8 days ago
I just check the file, the only differences are on 2 lines, it's the absolute path to the project which is different between environments.
To verify it:
### For background.js
```bash=
$ cat build/background.js | sed 's/;/;\n/g' > background-build.js
$ cat duniter-connect-firefox/background.js | sed 's/;/;\n/g' > background-firefox.js
$ diff background-*.js
```
Result is:
```bash=
3385c3385
< return e.map((e=>`\t${t(e.version.padEnd(n),e).join("\t")}`)).join("\n")}(t,n)}`)}const xh=[{name:"@polkadot/ui-settings",path:new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/ui-settings/packageInfo.js").pathname.substring(0,new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/ui-settings/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"}];
---
> return e.map((e=>`\t${t(e.version.padEnd(n),e).join("\t")}`)).join("\n")}(t,n)}`)}const xh=[{name:"@polkadot/ui-settings",path:new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/ui-settings/packageInfo.js").pathname.substring(0,new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/ui-settings/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"}];
3399c3399
< t.length&&vh(`${e} requires direct dependencies exactly matching version ${i}.`,t,gh)}else vh(`${e} has multiple versions, ensure that there is only one installed.`,o,bh)}({name:"@polkadot/ui-keyring",path:new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/ui-keyring/packageInfo.js").pathname.substring(0,new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/ui-keyring/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"},null,xh);
---
> t.length&&vh(`${e} requires direct dependencies exactly matching version ${i}.`,t,gh)}else vh(`${e} has multiple versions, ensure that there is only one installed.`,o,bh)}({name:"@polkadot/ui-keyring",path:new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/ui-keyring/packageInfo.js").pathname.substring(0,new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/ui-keyring/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"},null,xh);
```
### For extension.js
```bash=
$ cat build/extension.js | sed 's/;/;\n/g' > extension-build.js
$ cat duniter-connect-firefox/extension.js | sed 's/;/;\n/g' > extension-firefox.js
$ diff extension-*.js
```
Result is:
```bash=
9725c9725
< return e.map((e=>`\t${t(e.version.padEnd(n),e).join("\t")}`)).join("\n")}(t,n)}`)}const UC=[{name:"@polkadot/ui-settings",path:new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/ui-settings/packageInfo.js").pathname.substring(0,new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/ui-settings/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"},{name:"@polkadot/ui-shared",path:new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/ui-shared/packageInfo.js").pathname.substring(0,new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/ui-shared/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"}];
---
> return e.map((e=>`\t${t(e.version.padEnd(n),e).join("\t")}`)).join("\n")}(t,n)}`)}const UC=[{name:"@polkadot/ui-settings",path:new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/ui-settings/packageInfo.js").pathname.substring(0,new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/ui-settings/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"},{name:"@polkadot/ui-shared",path:new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/ui-shared/packageInfo.js").pathname.substring(0,new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/ui-shared/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"}];
9732c9732
< t.length&&HC(`${e} requires direct dependencies exactly matching version ${a}.`,t,_C)}else HC(`${e} has multiple versions, ensure that there is only one installed.`,s,DC)}({name:"@polkadot/react-identicon",path:new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/react-identicon/packageInfo.js").pathname.substring(0,new URL("file:///opt/dev/duniter-connect/node_modules/@polkadot/react-identicon/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"},null,UC);
---
> t.length&&HC(`${e} requires direct dependencies exactly matching version ${a}.`,t,_C)}else HC(`${e} has multiple versions, ensure that there is only one installed.`,s,DC)}({name:"@polkadot/react-identicon",path:new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/react-identicon/packageInfo.js").pathname.substring(0,new URL("file:///home/test/Downloads/duniter-connect-0.47.2-src/duniter-connect-master/node_modules/@polkadot/react-identicon/packageInfo.js").pathname.lastIndexOf("/")+1),type:"esm",version:"3.6.4"},null,UC);
```
So this is why the build is not exactly reproductible, but you can confirm this is just the absolute path to the project that way.
## Réponse d’un relecteur by Add-ons Review Team 2 days ago
Thank you for the elaborate answer. One more question before I can close the review: why are you using unsafe-eval in script-src directive inside the CSP? eval is rarely needed. Please explain why you need to use it or remove it.
## Réponse d’un développeur by Axiom-Team 2 days ago
The eval information is needed for the wasm/webpack.
This extension is a fork of polkadot.js extension, which is allowed on this store for years.
You can found the orignal answer of your question here: https://github.com/polkadot-js/extension/issues/104
## Approuvé by Add-ons Review Team about 2 hours ago
Thank you for your contribution.